fix(reactivity): fix currentScope loss when running detached effect scope (#5575)

2022-04-12 15:51:05 +08:00
parent cee1eafb4d
commit 0a301d4dab
2 changed files with 23 additions and 2 deletions
--- a/packages/reactivity/tests/effectScope.spec.ts
+++ b/packages/reactivity/tests/effectScope.spec.ts
@@ -6,7 +6,8 @@ import {
  onScopeDispose,
  computed,
  ref,
-  ComputedRef
+  ComputedRef,
+  getCurrentScope
 } from '../src'

 describe('reactivity/effect/scope', () => {
@@ -263,4 +264,17 @@ describe('reactivity/effect/scope', () => {
    expect(watchSpy).toHaveBeenCalledTimes(1)
    expect(watchEffectSpy).toHaveBeenCalledTimes(2)
  })
+
+  it('getCurrentScope() stays valid when running a detached nested EffectScope', () => {
+    const parentScope = new EffectScope()
+
+    parentScope.run(() => {
+      const currentScope = getCurrentScope()
+      expect(currentScope).toBeDefined()
+      const detachedScope = new EffectScope(true)
+      detachedScope.run(() => {})
+
+      expect(getCurrentScope()).toBe(currentScope)
+    })
+  })
 })