From f7ecb886593726eee3a531ee81377a10000959fa Mon Sep 17 00:00:00 2001 From: Thomas Letsch Groch Date: Tue, 2 Jun 2020 20:34:02 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=91=8C=20Code=20review=20changes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit commented out mysql logic and refine GUIDE.md --- GUIDE.md | 4 ++-- shynet/shynet/settings.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/GUIDE.md b/GUIDE.md index b52fe8c..36bc54c 100644 --- a/GUIDE.md +++ b/GUIDE.md @@ -10,7 +10,7 @@ + [Cloudflare](#cloudflare) + [Nginx](#nginx) + [Troubleshooting](#troubleshooting) -+ [Quick Deploy](#quick-deploy) ++ [Quick Deploy to Heroku](#quick-deploy-to-heroku) --- ## Staying Updated @@ -188,6 +188,6 @@ Here are solutions for some common issues. If your situation isn't described her * The problem is likely that to Shynet, `localhost` points to the local network in the container itself, not on the host machine. Try adding the `--network='host'` option when you run Docker. -## Quick Deploy +## Quick Deploy to Heroku [![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy?template=https://github.com/milesmcc/shynet/tree/master&env[SHYNET_HOST]=shynet-demo.herokuapp.com) diff --git a/shynet/shynet/settings.py b/shynet/shynet/settings.py index b915995..dec9c81 100644 --- a/shynet/shynet/settings.py +++ b/shynet/shynet/settings.py @@ -134,9 +134,9 @@ if 'DATABASE_URL' in os.environ: }) if url.scheme == 'postgres': DATABASES['default']['ENGINE'] = 'django.db.backends.postgresql_psycopg2' - - if url.scheme == 'mysql': - DATABASES['default']['ENGINE'] = 'django.db.backends.mysql' + # DEADCODE: mysql not supported for now + # if url.scheme == 'mysql': + # DATABASES['default']['ENGINE'] = 'django.db.backends.mysql' # Password validation